fix(slack): replace deprecated @slack/events-api with native crypto validation#4313
Merged
Conversation
angelcaamal
added
api: cloudfunctions
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the @slack/events-api dependency with a manual implementation of Slack webhook signature verification using the Node.js crypto module. The changes include a new verifyWebhook function and updated integration and unit tests to support the manual signing process. Feedback was provided to enhance security by implementing replay attack protection via timestamp verification, adding explicit checks for the signing secret, and optimizing the HMAC calculation process.
XrossFox
reviewed
May 13, 2026
|
LGTM |
Contributor
Author
|
Changes included:
|
iennae
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the Slack function sample to remove the deprecated
@slack/events-apilibrary. The request validation has been rewritten to use manual signature verification with the native Node.jscryptomodule.Additionally, the test suite has been updated to reflect these changes and ensure stability in the CI pipeline.
Changes included:
@slack/events-apidependency. Implemented native webhook verification using thecryptomodule. This includes protection against replay attacks (by enforcing a 5-minute request timestamp window) and timing attacks (usingcrypto.timingSafeEqual).@googleapis/kgsearchclient calls to use nativeasync/awaitinstead of outdated callback patterns (new Promisewrappers).test/unit.test.jsto correctly use.resolves()and.rejects()to match the new Promise-based API calls, replacing the old.yields()callback stubs.Fixes Internal: b/414440396
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.